If you're asking specifically about the eye-slits or oculars, there was a large variety in how they show up in the historical record. They're all different compromises for the trade-off of vision vs. protection. It seems the most common type of historical ocular is a plain eye slit, kept very narrow for protection. But we also see experimentation with extra sight holes, barred oculars, semi-barred oculars, blocked oculars (similar to your helmet), and even oculars with little tooth-like protrusions to catch a blade and prevent penetration.
Obviously your vision will be more obscured with that style of ocular but it is certainly safer. A lot of modern groups that do half-swording tend to require oculars that are more protected than just plain eye-slits for this very reason, since ultimately we're not trying to really hurt each other.
If you're concern is historical accuracy, your helmet isn't too historically shaped and has some modern safety features, but if you just want yo protect your head for practice / larping, as long as the construction is solid, it fits you, and it meets your needs, you should be fine!
Here are historical examples of each type of ocular I described above:
Far an away the most common visor ocular we see is a plain slit that's very narrow -
They experimented with 'extra' holes above and below plain slits to aid in vision -
An example of a historical barred ocular -
An example of a historical semi-barred ocular -
An example of a historical square blocked ocular -
An example of a historical toothed ocular -
